Feat update testing fixtures #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MOshima-PIFSC The r package checker found errors in the test code, but it was due to checking if stock synthesis was installed in my system, r4ss has a test_that method that skips the test if the stock synthesis executable is not on the system: https://github.com/r4ss/r4ss/blob/9d592166e3415f61875a9e19bc0741c0a0c5a5b0/tests/testthat/test-runs.R#L20) |
Closed
…SCstockassessments/ss3diags into FEAT-update-testing-fixtures
…SCstockassessments/ss3diags into FEAT-update-testing-fixtures
|
R-package check with bugfixes resolves #89 issue. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes included in this PR:
system.file("extdata", "simple_small", package = "r4ss")These changes will move us toward being able to remove the large .rda files (simple.rda and retroSimple.rda) in the future. The next step will be during the documentation milestone to update the vignettes to use these structures.
This new workflow should replace the current
call-r-cmd-check.ymlworkflow.